Re: [Proposal] Adding Log File Capability to pg_createsubscriber

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
Date: 2026-03-31 12:06:22
Message-ID: 4c2eb422-696c-4e34-84e7-6c6cd95781ab@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25.03.26 09:25, Amit Kapila wrote:
> On Wed, Mar 25, 2026 at 5:43 AM Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> wrote:
>>
>> Thank you, Kuroda-san and Chao for the suggestions and the patch. I have merged it with v18-0001, and I have fixed everything that Peter suggested.
>>
>
> Pushed after minor changes.

Instead of creating a new logging API in pg_createsubscriber locally,
why not extend logging.c to support a log file. This is much simpler,
doesn't require caller changes, and could be reused elsewhere. See
attached patches. (The 0003 and 0004 are just some additional code
simplifications.)

Attachment Content-Type Size
v20-0001-Add-log-file-support-to-logging.c.patch text/plain 3.5 KB
v20-0002-pg_createsubscriber-Use-logging.c-log-file-callb.patch text/plain 64.2 KB
v20-0003-pg_createsubscriber-Remove-separate-logfile_open.patch text/plain 1.5 KB
v20-0004-pg_createsubscriber-Don-t-use-MAXPGPATH.patch text/plain 1.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2026-03-31 12:07:42 RE: Initial COPY of Logical Replication is too slow
Previous Message Hayato Kuroda (Fujitsu) 2026-03-31 11:39:01 RE: Initial COPY of Logical Replication is too slow