Re: \crosstabview fixes

From: "Daniel Verite" <daniel(at)manitou-mail(dot)org>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Christoph Berg" <myon(at)debian(dot)org>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: \crosstabview fixes
Date: 2016-04-14 19:59:52
Message-ID: 4c28c3ed-4fd4-4e7d-9974-3bb0fa00faaa@mm
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

> I wrote:
> > My feeling is that what we should do is undo the change to use OT_SQLID,
> > and in indexOfColumn() perform a downcasing/dequoting conversion that
> > duplicates what OT_SQLID does in psqlscanslash.l.
>
> Here's an updated patch that does it that way, and also adopts Christoph's
> documentation suggestion about "sortcolH". Any further comments?

For my part, I'm fine with this. Thanks!

Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2016-04-14 20:29:32 Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls
Previous Message Julien Rouhaud 2016-04-14 19:42:10 Memory leak when querying GIN indexes