| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Joseph Koshakow <koshy44(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: date_trunc invalid units with infinite value |
| Date: | 2025-08-06 11:07:25 |
| Message-ID: | 4bf60a84-2862-4a53-acd5-8eddf134a60e@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27.12.24 05:42, Michael Paquier wrote:
> On Tue, Dec 24, 2024 at 04:33:47PM +0900, Michael Paquier wrote:
>> I am planning to get this one applied around the end of this week on
>> Friday for HEAD, that should be enough if there are comments and/or
>> objections.
>
> And done for now. If there are any remarks and/or objections, of
> course feel free.
It turned out this had a bug, and also the newly added test cases didn't
actually cover the new code, otherwise this would have shown up.
Please review the attached patches with additional test cases and the fix.
See also [0] for further context:
[0]:
https://www.postgresql.org/message-id/8246d7ff-f4b7-4363-913e-827dadfeb145%40eisentraut.org
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-test-coverage-of-date_trunc-on-infinity.patch | text/plain | 5.8 KB |
| 0002-Fix-incorrect-Datum-conversion-in-timestamptz_trunc_.patch | text/plain | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-08-06 11:07:34 | Re: Datum as struct |
| Previous Message | shveta malik | 2025-08-06 10:59:39 | Re: Logical Replication of sequences |