| From: | Vik Fearing <vik(at)postgresfriends(dot)org> |
|---|---|
| To: | Surafel Temesgen <surafel3000(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Rémi Lapeyre <remi(dot)lapeyre(at)lenstra(dot)fr>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Eli Marmor <eli(at)netmask(dot)it>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Georgios <gkokolatos(at)protonmail(dot)com>, Li Japin <japinli(at)hotmail(dot)com> |
| Subject: | Re: WIP: System Versioned Temporal Table |
| Date: | 2021-03-10 17:02:53 |
| Message-ID: | 4ba71e76-c038-1e2a-19d7-d3c084902cf6@postgresfriends.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/10/21 5:49 PM, Surafel Temesgen wrote:
> hi Ibrar,
> thank you for rebasing
>
> On Mon, Mar 8, 2021 at 9:34 AM Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
>
>>
>>> Since the get_row_start_time_col_name() and get_row_end_time_col_name()
>>> are similar, IMO we can pass a flag to get StartTime/EndTime column name,
>>> thought?
>>>
>>>
> For me your option is better. i will change to it in my next
> patch if no objection
I have plenty of objection. I'm sorry that I am taking so long with my
review. I am still working on it and it is coming soon, I promise.
--
Vik Fearing
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2021-03-10 17:05:38 | Re: cryptohash: missing locking functions for OpenSSL <= 1.0.2? |
| Previous Message | Surafel Temesgen | 2021-03-10 16:58:16 | Re: Evaluate expression at planning time for two more cases |