Re: how to run encoding-dependent tests by default

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: how to run encoding-dependent tests by default
Date: 2019-06-17 16:36:10
Message-ID: 4b31aeab-cc22-427b-62ca-ad960bd89023@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 6/17/19 11:32 AM, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> There is a fair amount of collation-related functionality that is only
>> being tested by sql/collate.icu.utf8.sql and sql/collate.linux.utf8.sql,
>> which are not run by default. There is more functionality planned in
>> this area, so making the testing more straightforward would be useful.
>> The reason these tests cannot be run by default (other than that they
>> don't apply to each build, which is easy to figure out) is that
>> a) They contain UTF8 non-ASCII characters that might not convert to
>> every server-side encoding, and
>> b) The error messages mention the encoding name ('ERROR: collation
>> "foo" for encoding "UTF8" does not exist')
>> The server encoding can be set more-or-less arbitrarily for each test
>> run, and moreover it is computed from the locale, so it's not easy to
>> determine ahead of time from a makefile, say.
>> What would be a good way to sort this out? None of these problems are
>> terribly difficult on their own, but I'm struggling to come up with a
>> coherent solution.
> Perhaps set up a separate test run (not part of the core tests) in which
> the database is forced to have UTF8 encoding? That could be expanded
> to other encodings too if anyone cares.
>
>

I should point out that the buildfarm does run these tests for every
utf8 locale it's configured for if the TestICU module is enabled. At the
moment the only animal actually running those tests is prion, for
en_US.utf8.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-06-17 16:39:21 Re: how to run encoding-dependent tests by default
Previous Message Stephen Frost 2019-06-17 15:41:33 Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions