| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: WIP: Covering + unique indexes. |
| Date: | 2018-04-19 08:09:29 |
| Message-ID: | 4acd0220-ff2a-0a63-ae1f-bb83f1adbab2@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you, pushed
Peter Geoghegan wrote:
> On Wed, Apr 18, 2018 at 10:47 PM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>> Thank you, pushed.
>
> Thanks.
>
> I saw another preexisting issue, this time one that has been around
> since 2007. Commit bc292937 forgot to remove a comment above
> _bt_insertonpg() (the 'afteritem' stuff ended up being moved to the
> bottom of _bt_findinsertloc(), where it remains today). The attached
> patch fixes this, and in passing mentions the fact that
> _bt_insertonpg() only performs retail insertions, and specifically
> never inserts high key items.
>
> I don't think it's necessary to add something about negative infinity
> items to the same comment block. While it's true that _bt_insertonpg()
> cannot truncate downlinks to make new minus infinity items, I see that
> as a narrower issue.
>
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-04-19 08:27:54 | Re: Boolean partitions syntax |
| Previous Message | Yuriy Zhuravlev | 2018-04-19 08:07:55 | Re: Is a modern build system acceptable for older platforms |