| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: msys2 vs pg_upgrade/test.sh |
| Date: | 2019-09-09 08:48:55 |
| Message-ID: | 4a76b98b-4a00-7df2-8912-9363277b604f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-09-09 00:06, Andrew Dunstan wrote:
> Diagnosing this took quite a lot of time and detective work. For some
> reason I don't quite understand, when calling the Windows command
> processor in a modern msys2/WindowsServer2019 installation, you need to
> double the slash, thus:
>
> cmd //c foo.bat
>
> Some Internet postings at least seem to suggest this is by design. (FSVO
> "design")
>
> I tested this on older versions and the change appears to work, so I
> propose to apply the attached patch.
If we're worried about messing things up for non-msys2 environments, we
could also set MSYS2_ARG_CONV_EXCL instead; see
<https://github.com/msys2/msys2/wiki/Porting#filesystem-namespaces>.
According to that page, that would seem to be the more proper way to do it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2019-09-09 09:25:32 | patch: psql - enforce constant width of last column |
| Previous Message | Peter Eisentraut | 2019-09-09 08:42:56 | Re: BUG #15977: Inconsistent behavior in chained transactions |