| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Identify LWLocks in tracepoints |
| Date: | 2021-05-08 15:04:01 |
| Message-ID: | 4a0ca956-f2eb-ee72-4639-eca3b48f1f49@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05.05.21 00:15, Andres Freund wrote:
> I'm now getting
>
> /home/andres/src/postgresql/src/backend/storage/lmgr/lwlock.c: In function ‘LWLockAcquire’:
> /home/andres/src/postgresql/src/backend/storage/lmgr/lwlock.c:1322:58: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> 1322 | TRACE_POSTGRESQL_LWLOCK_WAIT_START(T_NAME(lock), mode);
> | ^
For clarification, -Wempty-body is not part of the default warnings, right?
And even if I turn it on explicitly, I don't get this warning. I read
something that newer compilers don't warn in cases of macro expansion.
What compiler are you using in this situation?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2021-05-08 15:29:01 | Re: plan with result cache is very slow when work_mem is not enough |
| Previous Message | Dilip Kumar | 2021-05-08 14:49:03 | Re: Small issues with CREATE TABLE COMPRESSION |