Re: Review items for EXCEPT TABLE publication

> On Sep 10, 2026, at 13:39, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
>
> Finding #4: Test uses a stale subscription
>
> tap_sub is not dropped between the two multi-publication sub-tests. As
> a result, the second CREATE SUBSCRIPTION tap_sub fails with "already
> exists". Since the command uses psql(), the error is ignored.
> The subsequent assertions therefore run against the existing
> subscription rather than the intended fresh one. This means the test
> does not exercise the intended scenario: a fresh subscription whose
> initial COPY of tab1 must occur because tap_pub2 FOR ALL TABLES
> overrides tap_pub1's EXCEPT clause.
>
> Fixed this by dropping the subscription before recreating it.
>
>
> Regards,
> Vignesh
> <v1-0001-Fix-ALTER-PUBLICATION-race-with-concurrent-SET-AL.patch><v1-0005-Prevent-unlogged-tables-in-publication-EXCEPT-cla.patch><v1-0003-Fix-missing-check-in-test_except_root_partition.patch><v1-0002-Fix-ALTER-PUBLICATION-validation-race.patch><v1-0004-Fix-test-to-use-a-fresh-subscription.patch>

v1-0001 looks good to me. Changing to safe_psql() ensures that errors are not silently ignored, and dropping tap_sub ensures that the second case uses a fresh subscription as intended. I also ran the test, and it passed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/