Re: pldebugger targetinfo file missing

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Dharmendra Goyal <dharmendra(dot)goyal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pldebugger targetinfo file missing
Date: 2012-04-20 14:27:26
Message-ID: 4F91724E.7040105@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On 19.04.2012 15:25, Heikki Linnakangas wrote:
> On 19.04.2012 15:20, Dharmendra Goyal wrote:
>> pldebugger build is failing on WIndows because targetinfo.c file is not
>> there where as vcproj file requires it to be there to build
>> targetinfo.dll.
>> I checked earlier this file was there and after moving to git we started
>> seeing this issue.
>>
>> If we have removed this file intentionally then it has to be removed from
>> vcproj file also.
>>
>> Comments..??
>
> Hmm, looks like I broke the Windows build with my recent changes.
> targetinfo.c file is gone, it's no longer needed as I rewrote the
> function that used to be in it in plain SQL.
>
> I haven't tested on Windows, so it's very possible there's other stuff
> broken, too. Please let me know if so. Or even better, post a patch ;-).

I bit the bullet and dug out my Windows VM. I've now pushed changes that
should make the MSVC build work on Windows. Let me know if it still
doesn't work for you.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2012-04-20 15:06:37 pgAdmin III commit: Fix debugger hanging pgAdmin
Previous Message Dharmendra Goyal 2012-04-20 12:12:44 Re: pldebugger targetinfo file missing