Re: [patch] for "psql : Allow processing of multiple -f (file) options "

From: Euler Taveira <euler(at)timbira(dot)com>
To: Vikash3 S <vikash3(dot)s(at)tcs(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [patch] for "psql : Allow processing of multiple -f (file) options "
Date: 2012-04-09 13:12:36
Message-ID: 4F82E044.6080202@timbira.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09-04-2012 02:43, Vikash3 S wrote:
> Please find the patch regarding trivial changes against To Do item list for
> "psql : Allow processing of multiple -f (file) options ".
> Looking for valuable feedback.
>
Aren't you forget to cover the single transaction (-1) mode? How would you
handle ON_ERROR_* options? Look at the archives for references. Also, your
disclaimer doesn't seems attractive; make it clear you're contributing code
under the PostgreSQL license.

--
Euler Taveira de Oliveira - Timbira http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-04-09 13:25:36 Re: Last gasp
Previous Message Andrew Dunstan 2012-04-09 12:49:44 Re: why was the VAR 'optind' never changed in initdb?