| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cluster::restart dumping logs when stop fails |
| Date: | 2024-04-07 14:52:05 |
| Message-ID: | 4F7EF0B0-1658-40DC-884C-593581AF9FFE@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 7 Apr 2024, at 14:51, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> On 2024-04-06 Sa 20:49, Andres Freund wrote:
>> That's probably unnecessary optimization, but it seems a tad silly to read an
>> entire, potentially sizable, file to just use the last 1k. Not sure if the way
>> slurp_file() uses seek supports negative ofsets, the docs read to me like that
>> may only be supported with SEEK_END.
>
> We should enhance slurp_file() so it uses SEEK_END if the offset is negative.
Absolutely agree. Reading the thread I think Andres argues for not printing
anything at all in this case but we should support negative offsets anyways, it
will fort sure come in handy.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-04-07 14:54:56 | Re: BitmapHeapScan streaming read user and prelim refactoring |
| Previous Message | Tomas Vondra | 2024-04-07 14:41:59 | Re: BitmapHeapScan streaming read user and prelim refactoring |