Re: [PATCH] Fix float8 parsing of denormal values (on some platforms?)

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marti Raudsepp <marti(at)juffo(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jeroen Vermeulen <jtv(at)xs4all(dot)nl>
Subject: Re: [PATCH] Fix float8 parsing of denormal values (on some platforms?)
Date: 2012-02-03 09:06:01
Message-ID: 4F2BA379.1030807@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/03/2012 03:49 AM, Tom Lane wrote:
> Marti Raudsepp<marti(at)juffo(dot)org> writes:
>> We're already seeing first buildfarm failures, on system "narwhal"
>> using an msys/mingw compiler.
> Yeah. After a full day's cycle, the answer seems to be that
> denormalized input works fine everywhere except:
>
> 1. mingw on Windows (even though MSVC builds work)
>
> 2. some Gentoo builds fail (knowing that platform, the phase of the moon
> is probably the most predictable factor determining this).
>
> I'm inclined at this point to remove the regression test cases, because
> we have no principled way to deal with case #2. We could install
> alternative "expected" files that accept the failure, but then what's
> the point of having the test case at all?
>
> It might be worth pressuring the mingw folk to get with the program,
> but I'm not going to be the one to do that.
>
>

No doubt they would tell us to upgrade the compiler. Narwhal's is
horribly old. Neither of my mingw-based members is failing.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bernd Helmle 2012-02-03 09:10:11 Re: Patch pg_is_in_backup()
Previous Message Tom Lane 2012-02-03 08:49:38 Re: [PATCH] Fix float8 parsing of denormal values (on some platforms?)