Re: [COMMITTERS] pgsql: Make group commit more effective.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Make group commit more effective.
Date: 2012-01-30 20:50:28
Message-ID: 4F270294.102@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 30.01.2012 20:27, Robert Haas wrote:
> Either this patch, or something else committed this morning, is
> causing "make check" to hang or run extremely slowly for me. I think
> it's this patch, because I attached to a backend and stopped it a few
> times, and all the backtraces look like this:

Yeah, sure looks like it's the group commit commit. It works for me, and
staring at the code, I have no idea what could be causing it. The
buildfarm seems happy too, so this is pretty mysterious.

I did find one bug, see attached, but AFAICS it should only cause
unnecessary wakeups in some corner cases, which is harmless.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

Attachment Content-Type Size
fix-releaseok.patch text/x-diff 988 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-01-30 21:06:05 Re: [COMMITTERS] pgsql: Make group commit more effective.
Previous Message Peter Eisentraut 2012-01-30 19:49:47 pgsql: Use abort() instead of exit() to abort library functions

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-01-30 21:06:05 Re: [COMMITTERS] pgsql: Make group commit more effective.
Previous Message Robert Haas 2012-01-30 20:24:25 Re: CLOG contention, part 2