unfriendly error when accessing NEW in statement-level trigger

From: Jan Urbański <wulczer(at)wulczer(dot)org>
To: Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: unfriendly error when accessing NEW in statement-level trigger
Date: 2012-01-28 23:00:38
Message-ID: 4F247E16.9070606@wulczer.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

When you try to use the NEW variable in a statement-level trigger, you get

ERROR: record "new" is not assigned yet
DETAIL: The tuple structure of a not-yet-assigned record is indeterminate.

which is not too friendly, given that people sometimes forget to specify
FOR EACH <sth> at all, get the default behaviour of FOR EACH STATEMENT
and scratch their heads. A quick search on the error detail reveals a
few such confused users already.

What's more, the documentation for PL/pgSQL triggers says that "This
variable is NULL in statement-level triggers" but it's not really a
NULL, for instance you can't execute "x is NULL" with it (you get the
same error).

I'm not that familiar with PL/pgSQL code, so I'm not sure how or if this
should be fixed. From a quick look it seems that the NEW and OLD
variables could be defined as row variables instead of record, since the
format of the tuple is known.

Would that make sense?

Cheers,
Jan

PS: If changing them to row types would induce too much code churn that
maybe we could use some trick to check if the error comes from using the
OLD or NEW variable and add a HINT to the error message?

J

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-01-28 23:05:41 Re: Second thoughts on CheckIndexCompatible() vs. operator families
Previous Message Alvaro Herrera 2012-01-28 22:52:07 Re: isolationtester seems uselessly rigid as to length of permutation