| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: making the backend's json parser work in frontend code |
| Date: | 2020-01-24 19:50:00 |
| Message-ID: | 4F0F5B2F-6907-479B-9664-21090BE42B5C@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jan 24, 2020, at 10:43 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> Since 0001-0003 have been reviewed by multiple people and nobody's
> objected, I have committed those.
I think 0004-0005 have been reviewed and accepted by both me and Andrew, if I understood him correctly:
> I've reviewed these patches and Robert's, and they seem basically good to me.
Certainly, nothing in those two patches caused me any concern. I’m going to modify my patches as you suggested, get rid of the INSIST macro, and move the pg_wchar changes to their own thread. None of that should require changes in your 0004 or 0005. It won’t bother me if you commit those two. Andrew?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-01-24 19:52:26 | pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |
| Previous Message | Pavel Stehule | 2020-01-24 19:39:17 | Re: [Proposal] Global temporary tables |