| From: | Greg Smith <greg(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Marti Raudsepp <marti(at)juffo(dot)org> |
| Cc: | Jaime Casanova <jaime(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Caching for stable expressions with constant arguments v3 |
| Date: | 2011-12-16 07:13:21 |
| Message-ID: | 4EEAEF91.6070400@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I think what would be helpful here next is a self-contained benchmarking
script. You posted an outline of what you did for the original version
at
http://archives.postgresql.org/message-id/CABRT9RC-1wGxZC_Z5mwkdk70fgY2DRX3sLXzdP4voBKuKPZDow@mail.gmail.com
It doesn't sound like it would be hard to turn that into a little shell
script. I'd rather see one from you mainly so I don't have to worry
about whether I duplicated your procedure correctly or not. Don't even
worry about "best of 3", just run it three times, grep out the line that
shows the TPS number, and show them all. One of the first questions I
have is whether the performance changed between there and your v5. A
self-contained and fully automated performance test case would ease
review, and give some performance regression testing for other suggested
changes to use as a reference.
--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.us
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lionel Elie Mamane | 2011-12-16 08:35:31 | Re: LibreOffice driver 1: Building libpq with Mozilla LDAP instead of OpenLDAP |
| Previous Message | Greg Smith | 2011-12-16 07:02:03 | Re: Measuring relation free space |