From: | Yeb Havinga <yebhavinga(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Royce Ausburn <royce(dot)ml(at)inomial(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [REVIEW] Patch for cursor calling with named parameters |
Date: | 2011-11-14 14:45:35 |
Message-ID: | 4EC1298F.9010405@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2011-10-15 07:41, Tom Lane wrote:
> Yeb Havinga<yebhavinga(at)gmail(dot)com> writes:
>> Hello Royce,
>> Thanks again for testing.
> I looked this patch over but concluded that it's not ready to apply,
> mainly because there are too many weird behaviors around error
> reporting.
Thanks again for the review and comments. Attached is v3 of the patch
that addresses all of the points made by Tom. In the regression test I
added a section under --- START ADDITIONAL TESTS that might speedup testing.
> On the documentation front, the patch includes a hunk that changes the
> description of DECLARE to claim that the argument names are optional,
> something I see no support for in the code. It also fails to document
> that this patch affects the behavior of cursor FOR loops as well as OPEN,
> since both of those places use read_cursor_args().
The declare section was removed. The cursor for loop section was changed
to include a reference to named parameters, however I was unsure about
OPEN as I was under the impression that was already altered.
regards,
Yeb Havinga
Attachment | Content-Type | Size |
---|---|---|
cursornamedparameter-v3.patch | text/x-patch | 21.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thom Brown | 2011-11-14 15:05:28 | Re: Detach/attach database |
Previous Message | Peter Eisentraut | 2011-11-14 14:24:17 | Re: Working with git repo tagged versions |