| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Leonardo Bispo de Oliveira <leonardo(dot)oliveira(at)voipfuture(dot)com> |
| Subject: | Re: DatumGetInetP buggy |
| Date: | 2011-11-08 20:52:43 |
| Message-ID: | 4EB9969B.7010609@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.11.2011 20:46, Boszormenyi Zoltan wrote:
> 2011-11-08 18:53 keltezéssel, Heikki Linnakangas írta:
>> What do people think of backpatching this? I'm inclined to backpatch, on the grounds
>> that the macro that detoasts and depacks should always work (ie. after this patch), even
>> if the depacking isn't necessary and introduces an extra palloc+copy, but the reverse is
>> not true.
>
> On the grounds that 9.0.x also shows the problem with
> the stock macro, backporting would be nice. I don't know
> which older trees may show the problem, I only tested with
> 9.0 and 9.1.
Packed varlenas were introduced in 8.3 - this hasn't changed since then.
Committed and backpatched all the way to 8.3.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2011-11-08 20:56:14 | Releasing an alpha for CF2 |
| Previous Message | Greg Jaskiewicz | 2011-11-08 19:46:44 | 9.1.2 ? |