| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: REVIEW: Optimizing box_penalty |
| Date: | 2011-10-09 16:01:07 |
| Message-ID: | 4E91C543.60303@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.10.2011 21:51, Kevin Grittner wrote:
> I tried to review the "Optimizing box_penalty" patch:
Thanks!
> On the other hand, this patch leaves the code a few lines shorter and
> eliminates some unnecessary Datum wrapping, PG_FUNCTION_ARGS
> parameters on a static function, and allows that function to be
> called directly rather than using DirectFunctionCall2(). I find the
> resulting code a little cleaner and easier to read. I would prefer
> to see it applied on that basis, personally.
Agreed, committed.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-10-09 16:06:34 | Re: Range Types - typo + NULL string constructor |
| Previous Message | Tom Lane | 2011-10-09 15:58:59 | Re: Schema grants for creating and dropping objects |