REVIEW: Optimizing box_penalty

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: REVIEW: Optimizing box_penalty
Date: 2011-10-08 18:51:11
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I tried to review the "Optimizing box_penalty" patch:

as posted here:

The patch no longer applies to source code, due to other recent GiST
changes. Parts of it were modifying functions which no longer exist.
I picked out the bits which still seemed relevant, and a patch with
that is attached. The improvement in REINDEX time is now only about
0.25% on my machine at home, which is small enough that it could
easily be from code shifting around. (Or such shifts might be hiding
a larger actual savings.) In any event, this patch doesn't seem to
be justified as a performance patch, based on my benchmarks today.

On the other hand, this patch leaves the code a few lines shorter and
eliminates some unnecessary Datum wrapping, PG_FUNCTION_ARGS
parameters on a static function, and allows that function to be
called directly rather than using DirectFunctionCall2(). I find the
resulting code a little cleaner and easier to read. I would prefer
to see it applied on that basis, personally.

Since the author is a committer, and this is a pretty minor code
style patch at this point, I'll mark it "Ready for Committer" and
leave it to Heikki to decide what to do with it.


Attachment Content-Type Size
penalty-v2.patch application/octet-stream 3.0 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2011-10-08 19:44:52 Re: Range Types - typo + NULL string constructor
Previous Message Tom Lane 2011-10-08 16:30:08 Re: SET variable - Permission issues