Re: BUG #6216: Calling PQconnectdbParams from C++ with a char**

From: Craig Ringer <ringerc(at)ringerc(dot)id(dot)au>
To: Lionel Elie Mamane <lionel(at)mamane(dot)lu>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6216: Calling PQconnectdbParams from C++ with a char**
Date: 2011-09-23 06:24:26
Message-ID: 4E7C261A.3010908@ringerc.id.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 21/09/2011 4:25 PM, Lionel Elie Mamane wrote:
> I added my initial patch, and as far as I understand, I have to send
> the revised patch to the list before I can register it at the
> commitfest. So here is my revised patch, that uses "const char *const * "
> like elsewhere in the same file instead of "char const* const*".

Yep, I'm happy with that. It does what it says and no more.

I have *NOT* done any detailed testing, as I'm in the middle of moving
house, but I find it hard to see how it can break anything that isn't
its self incorrect. You can still pass a `char *' to a `const char *
const' param, so it won't break any call sites.

--
Craig Ringer

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Magnus Hagander 2011-09-23 08:49:21 Re: Timezone issues with Postrres
Previous Message Jaime Casanova 2011-09-23 05:05:21 Re: [BUGS] BUG #5206: wal_sync_method in stock postgresql.conf may be wrong