Re: pgsql: Buffering GiST index build algorithm.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Buffering GiST index build algorithm.
Date: 2011-09-09 05:17:26
Message-ID: 4E69A166.5010606@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 08.09.2011 23:44, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>>> Maybe we need to include math.h. And while we're about it, should the
>>> result of round() be cast to an int, since that's what the function
>>> returns?
>
>> Or use rint(), which we certainly have.
>
> Yeah, this broke the build on my old HPUX box too. I committed a quick
> fix using rint(),

Thanks!

> but on reflection I wonder if it shouldn't be ceil().

Doesn't really matter. The exact value of that parameter isn't critical
to the algorithm, and it can't go down to 0.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-09-09 15:34:12 Re: pgsql: Stamp 9.1.0.
Previous Message Tom Lane 2011-09-08 21:14:51 pgsql: Stamp 9.1.0.