Skip site navigation (1) Skip section navigation (2)

Re: setlocale() and gettext on Windows revisited

From: "Inoue, Hiroshi" <inoue(at)tpf(dot)co(dot)jp>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Dave Page <dave(dot)page(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: setlocale() and gettext on Windows revisited
Date: 2011-09-01 00:34:36
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
HI all,

(2011/09/01 4:30), Heikki Linnakangas wrote:
> Back in January/February, a patch was committed to avoid using libintl's
> version of setlocale:
> The comment says it was about a problem with printf() and friends, so I
> wonder, why was that "#undef setlocale" line put inside the larger
> "#ifdef USE_REPL_SNPRINTF" block? If I understand the problem correctly,
> it has nothing to do with our replacement snprintf() function.
> Fortunately, we always use the replacement snprintf() code on Windows,
> so there's no user-visible bug here, but if you imagine that we didn't
> USE_REPL_SNPRINTF on Windows, we would still want the "#undef setlocale"
> to take effect, right? I think that block is misplaced.

Yes you are right.
I didn't notice "#ifdef USE_REPL_SNPRINTF" unfortunately.
The "#undef setlocale" line should be placed outside the "ifdef 

Hiroshi Inoue

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-09-01 01:48:20
Subject: Re: [PATCH] Generate column names for subquery expressions
Previous:From: Tom LaneDate: 2011-08-31 22:54:34
Subject: Re: Bogus nestloop join estimate, ignores WHERE clause

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group