| From: | "Inoue, Hiroshi" <inoue(at)tpf(dot)co(dot)jp> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Dave Page <dave(dot)page(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: setlocale() and gettext on Windows revisited |
| Date: | 2011-09-01 00:34:36 |
| Message-ID: | 4E5ED31C.9010803@tpf.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
HI all,
(2011/09/01 4:30), Heikki Linnakangas wrote:
> Back in January/February, a patch was committed to avoid using libintl's
> version of setlocale:
>
> http://archives.postgresql.org/pgsql-hackers/2011-01/msg02628.php
>
> The comment says it was about a problem with printf() and friends, so I
> wonder, why was that "#undef setlocale" line put inside the larger
> "#ifdef USE_REPL_SNPRINTF" block? If I understand the problem correctly,
> it has nothing to do with our replacement snprintf() function.
>
> Fortunately, we always use the replacement snprintf() code on Windows,
> so there's no user-visible bug here, but if you imagine that we didn't
> USE_REPL_SNPRINTF on Windows, we would still want the "#undef setlocale"
> to take effect, right? I think that block is misplaced.
Yes you are right.
I didn't notice "#ifdef USE_REPL_SNPRINTF" unfortunately.
The "#undef setlocale" line should be placed outside the "ifdef
USE_REPL_SNPRINTF" block.
regards,
Hiroshi Inoue
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-01 01:48:20 | Re: [PATCH] Generate column names for subquery expressions |
| Previous Message | Tom Lane | 2011-08-31 22:54:34 | Re: Bogus nestloop join estimate, ignores WHERE clause |