Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Subject: Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)
Date: 2011-08-09 12:32:43
Message-ID: 4E4128EB.5040102@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09.08.2011 13:25, Heikki Linnakangas wrote:
> On 08.08.2011 22:11, Alvaro Herrera wrote:
>> Perhaps the easiest way to fix it is as you suggest, by declaring the
>> struct to take a pointer rather than the value directly. Not sure how
>> to make both cases work sanely; the add_string_reloption path will need
>> updates.
>
> Agreed, I propose the attached patch to do that.

Committed this.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message pasman pasmański 2011-08-09 13:10:25 Problem with sources.
Previous Message Peter Eisentraut 2011-08-09 11:38:11 some missing internationalization in pg_basebackup