Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

From: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Date: 2022-11-04 14:16:29
Message-ID: 4E379ADE-1FC3-4D53-BE46-562BDC77C5FE@crunchydata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Nov 4, 2022, at 9:02 AM, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> On Fri, Nov 04, 2022 at 11:52:59AM +0900, Ian Lawrence Barwick wrote:
>> 2022年5月3日(火) 8:45 David Christensen <david(dot)christensen(at)crunchydata(dot)com>:
>>>
>>> ...and pushing a couple fixups pointed out by cfbot, so here's v4.
>>
>> cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
>> currently underway, this would be an excellent time to update the patch.
>
> More important than needing to be rebased, the patch has never passed
> its current tests on windows.
>
> As I recall, that's due to relying on "cp". And "rsync", which
> shouldn't be assumed to exist by regression tests).

I will work on supporting the windows compatibility here. Is there some list of guidelines for what you can and can’t use? I don’t have a windows machine available to develop on.

Was it failing on windows? I was attempting to skip it as I recall.

Best,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-11-04 14:17:13 Re: Schema variables - new implementation for Postgres 15
Previous Message Dmitry Dolgov 2022-11-04 14:07:48 Re: Schema variables - new implementation for Postgres 15