Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Florian Pflug <fgp(at)phlo(dot)org>
Cc: Radosław Smogura <rsmogura(at)softperience(dot)eu>, Robert Haas <robertmhaas(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
Date: 2011-07-12 18:11:40
Message-ID: 4E1C8E5C.5040201@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Radoslaw,

> For me this discussion is over. I putted my objections and suggestions. Full
>> review is available in archives, and why to not escape is putted in review
>> of your 2nd patch, about scalar values.

Did you install and test the functionality of the patch? I can't tell
from your review whether you got that far.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2011-07-12 18:16:17 Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
Previous Message Jeff Davis 2011-07-12 17:02:01 Re: reducing the overhead of frequent table locks, v4