| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
| Cc: | drkp(at)csail(dot)mit(dot)edu, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: SSI modularity questions |
| Date: | 2011-06-29 19:18:00 |
| Message-ID: | 4E0B7A68.5030102@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29.06.2011 00:33, Kevin Grittner wrote:
> Heikki Linnakangas wrote:
>> On 28.06.2011 20:47, Kevin Grittner wrote:
>
>> Hmm, the calls in question are the ones in heapgettup() and
>> heapgettup_pagemode(), which are subroutines of heap_getnext().
>> heap_getnext() is only used in sequential scans, so it seems safe
>> to remove those calls.
>
> I haven't found anything to the contrary, if I understand correctly,
> Dan found the same, and all the tests pass without them. Here's a
> patch to remove them. This makes the recently-added
> rs_relpredicatelocked boolean field unnecessary, so that's removed in
> this patch, too.
Thanks, committed. I also moved the PredicateLockRelation() call to
heap_beginscan(), per earlier discussion.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2011-06-29 19:19:11 | Re: Repeated PredicateLockRelation calls during seqscan |
| Previous Message | Merlin Moncure | 2011-06-29 19:16:41 | Re: hint bit cache v6 |