Re: Correct error message for end-of-recovery record TLI

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Amul Sul <sulamul(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Correct error message for end-of-recovery record TLI
Date: 2021-10-28 19:52:51
Message-ID: 4E0AC2FB-2BAC-4768-9095-945D25E3BC54@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/28/21, 12:23 PM, "Robert Haas" <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Oct 28, 2021 at 8:59 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>> In xlog_redo, for end-of-recovery case error message describes the
>> record as a checkpoint record which seems to be incorrect; the
>> attached patch corrects that.
>
> The analysis and patch appear correct to me.

When I apply the patch, it changes the PANIC message in the
XLOG_CHECKPOINT_ONLINE section, not the XLOG_END_OF_RECOVERY one.

Nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2021-10-28 19:54:00 Re: Correct error message for end-of-recovery record TLI
Previous Message Kenaniah Cerny 2021-10-28 19:39:07 Re: Proposal: allow database-specific role memberships