From: | Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz> |
---|---|
To: | Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: patch review : Add ability to constrain backend temporary file space |
Date: | 2011-06-15 00:35:32 |
Message-ID: | 4DF7FE54.1090404@catalyst.net.nz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 15/06/11 02:52, Cédric Villemain wrote:
> 2011/6/3 Mark Kirkwood<mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>:
>>
>> Corrected v4 patch with the test files, for completeness. Note that
>> discussion has moved on and there will be a v5 :-)
>>
> Mark, can you submit your updated patch ?
>
Thanks for the reminder! Here is v5. The changes are:
- guc is called temp_file_limit, which seems like the best choice to
date :-)
- removed code to do with truncating files, as after testing I agree
with you that temp work files don't seem to get truncated.
I have not done anything about the business on units - so we are in KB
still - there is no MB unit avaiable in the code as yet - I'm not sure
we need one at this point, as most folk who use this feature will find
4096GB a big enough *per backend* limit. Obviously it might be a good
investment to plan to have MB, and GB as possible guc units too. Maybe
this could be a separate piece of work since any *other* resource
limiters we add might find it convenient to have these available?
Cheers
Mark
Attachment | Content-Type | Size |
---|---|---|
temp-files-v5.patch.gz | application/x-gzip | 3.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jaime Casanova | 2011-06-15 01:24:25 | Re: creating CHECK constraints as NOT VALID |
Previous Message | Greg Smith | 2011-06-15 00:10:47 | Re: procpid? |