Re: Missing File weather.txt

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, davidhowes(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Missing File weather.txt
Date: 2025-07-10 22:22:55
Message-ID: 4DF3BEAF-EAAA-4C91-92B3-2CA8F022B383@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-docs

> On 5 Jul 2025, at 19:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>> On 2020/01/28 19:18, Daniel Gustafsson wrote:
>>> This is only mentioned as an example of another input method, with a link to
>>> the COPY page for more information. That being said, it's a good thing for a
>>> tutorial to be self-contained, and going from a basic tutorial to the COPY
>>> reference page is a fairly large step. I propose that we add a small example
>>> on what weather.txt could look like as per the attached diff.
>
>> Sorry for reviving this old thread, but I wanted to follow up since
>> the same issue was reported again in [1], and the proposed patch
>> basically looks good to me.
>
> +1
>
>> In the tutorial, three rows are inserted using INSERT, so shouldn't
>> the sample input for COPY include all three, like this?
>
> Agreed, the example file should match what the tutorial expects to be
> in the table. I'd include text along the lines of "The data inserted
> above could also be inserted from a file containing:".

The attached v2 adds the missing line, and tweaks the text added to document
the file. Since there have been reports I propose backpatching this all the
way down to 13 while at it.

--
Daniel Gustafsson

Attachment Content-Type Size
v2-0001-doc-Add-example-file-for-COPY.patch application/octet-stream 1.8 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Fujii Masao 2025-07-10 23:36:38 Re: Missing File weather.txt
Previous Message Tom Lane 2025-07-10 20:32:12 Re: Outdated typedefs in documentation