Re: reducing the overhead of frequent table locks - now, with WIP patch

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: reducing the overhead of frequent table locks - now, with WIP patch
Date: 2011-06-06 10:19:54
Message-ID: 4DECA9CA.7050400@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06.06.2011 12:40, Simon Riggs wrote:
> On Sat, Jun 4, 2011 at 5:55 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Simon Riggs<simon(at)2ndquadrant(dot)com> writes:
>>> The approach looks sound to me. It's a fairly isolated patch and we
>>> should be considering this for inclusion in 9.1, not wait another
>>> year.
>>
>> That suggestion is completely insane. The patch is only WIP and full of
>> bugs, even according to its author. Even if it were solid, it is way
>> too late to be pushing such stuff into 9.1. We're trying to ship a
>> release, not find ways to cause it to slip more.
>
> In 8.3, you implemented virtual transactionids days before we produced
> a Release Candidate, against my recommendation.

FWIW, this bottleneck was not introduced by the introduction of virtual
transaction ids. Before that patch, we just took the lock on the real
transaction id instead.

> The fact that you disagree with me does not make me insane.

You are not insane, even if your suggestion is.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2011-06-06 10:51:45 Re: WIP: Fast GiST index build
Previous Message Simon Riggs 2011-06-06 09:40:40 Re: reducing the overhead of frequent table locks - now, with WIP patch