Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Dave Page <dave(dot)page(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox
Date: 2011-05-28 00:31:22
Message-ID: 4DE0425A.5050002@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le 05/27/2011 11:17 PM, Ashesh Vashi a écrit :
> Hi Dave,
>
> For some reason, the wxCalendarBox control was not working on linux (i.e.
> Ubuntu).
> I found that - wxWidgets has already provided a class for that.
> (wxDatePickerCtrl).
>
> http://docs.wxwidgets.org/stable/wx_wxdatepickerctrl.html
>
> As per our conversation, I have modified the code to use the
> wxDatePickerCtrl instead of wxCalendarBox.
> Please find the patch for the master branch.
>
> I have made minimal changes to work this control as per our expectation.
>
> I think - this is a bug, so we should apply this to REL-1_12 and REL-1_10
> branches too...
> If you want, I can generate the patches for them.
>
> Please review this patch and give your comments.
>

I'm mostly working on Linux (Ubuntu) and I don't really see the
differences. I mean, yeah, they're not the same, but it didn't feel bad
on Linux before. What are you trying to fix?

BTW, we don't release bugfixes for 1.10.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2011-05-28 04:57:56 Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox
Previous Message Dave Page 2011-05-28 00:21:50 Re: Problem trying to compile PgAdmin