Re: unknown conversion %m

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: unknown conversion %m
Date: 2011-04-28 18:49:07
Message-ID: 4DB9B6A3.50305@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/28/2011 12:41 PM, Tom Lane wrote:
>
>> c:/mingw/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.3240/../pgsql/src/interfaces/ecpg/pgtypeslib/timestamp.c:505:6:
>> warning: unknown conversion type character 'G' in format
>> c:/mingw/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.3240/../pgsql/src/interfaces/ecpg/pgtypeslib/timestamp.c:685:6:
>> warning: unknown conversion type character 'V' in format
> These are a bit interesting. According to the Single Unix Spec, %V
> has been standard for strftime since at least 1997, so it's damn odd
> if MS' version doesn't support that. OTOH, %G is *not* in that standard
> ... should we try to avoid using that?
>
> But it looks like all those cases are only reached if the ecpg-using
> application tries to use those formats, so maybe any portability risks
> there aren't our problem. Maybe a reasonable fix is the one that's
> already there for %g, ie, just prevent the gcc check from occurring.
>
>

I'll make that change if Michael's happy.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ernesto Lozano 2011-04-28 19:05:51 Re: [ANNOUNCE] [HACKERS] PostgreSQL Core Team
Previous Message Andrew Dunstan 2011-04-28 17:51:23 Re: XML with invalid chars