Re: [JDBC] JDBC connections to 9.1

From: Mike Fowler <mike(at)mlfowler(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dave Cramer <pg(at)fastcrypt(dot)com>, Bernd Helmle <mailings(at)oopsware(dot)de>, Steve Singer <ssinger(at)ca(dot)afilias(dot)info>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: [JDBC] JDBC connections to 9.1
Date: 2011-04-18 16:52:23
Message-ID: 4DAC6C47.4060307@mlfowler.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

On 18/04/11 17:12, Tom Lane wrote:
> Dave Cramer<pg(at)fastcrypt(dot)com> writes:
>> Well initially my concern was that people would have a challenge in
>> the case where they had to re-certify their application if we made
>> this change, however I realize they will have to do this anyway since
>> upgrading to 9.1 is what necessitates it.
> I don't see any backwards compatibility risk, if that's what you mean.
> Every backend release since 7.3 has treated client_encoding 'UTF8' and
> 'UNICODE' the same, and earlier releases didn't accept either one.
>
> regards, tom lane
>

As there seems to be a consensus forming for fixing the JDBC driver,
I've taken the liberty do so at the risk of being shot down. The patch
is fairly straightforward, just changing UNICODE to UTF8 in a number of
files including the translation files. I've tested this against 9.1devel
(HEAD) and 8.4.7. For each database version I build and the tests
running JDKs 1.4.2_19, 1.5.0_22 and 1.6.0_2. All on 32-bit.

Regards,

--
Mike Fowler
Registered Linux user: 379787

Attachment Content-Type Size
unicode-utf8-jdbc.patch text/x-diff 30.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua Berkus 2011-04-18 16:52:52 Re: Formatting Curmudgeons WAS: MMAP Buffers
Previous Message Merlin Moncure 2011-04-18 16:51:12 Re: WIP: Allow SQL-language functions to reference parameters by parameter name

Browse pgsql-jdbc by date

  From Date Subject
Next Message Kevin Grittner 2011-04-18 21:28:27 Test suite fails on non-default configuration
Previous Message Mike Fowler 2011-04-18 16:40:49 Re: [JDBC] JDBC connections to 9.1