Re: Remove unneeded cast in heap_xlog_lock.

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove unneeded cast in heap_xlog_lock.
Date: 2025-08-22 00:44:17
Message-ID: 4D99E889-BF09-4E5F-BD93-3E4262FEAF8D@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Aug 21, 2025, at 22:10, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> Hi!
>
> I was looking at how PostgreSQL handles VM map bits, when I noticed $subj.
> PFA small refactoring patch.
>
> --
> Best regards,
> Kirill Reshke
> <v1-0001-Remove-unneeded-cast-in-heap_xlog_lock.patch>

LGTM. BufferGetPage() returns a “Page” type, and the receiving variable “page” is of “Page” type as well, so the cast is not needed.

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-08-22 01:19:32 Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only
Previous Message torikoshia 2025-08-22 00:28:49 Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring