| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | daveg <daveg(at)sonic(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <gsstark(at)mit(dot)edu>, David Christensen <david(at)endpoint(dot)com>, Maxim Boguk <maxim(dot)boguk(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-admin(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum |
| Date: | 2011-03-03 08:16:29 |
| Message-ID: | 4D6F4E5D.6080507@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers |
On 03.03.2011 09:12, daveg wrote:
> Question: what would be the consequence of simply patching out the setting
> of this flag? Assuming that the incorrect PD_ALL_VISIBLE flag is the only
> problem (big assumption perhaps) then simply never setting it would at least
> avoid the possibility of returning wrong answers, presumably at some
> performance cost. We possibly could live with that until we get a handle
> on the real cause and fix.
Yes. With that assumption.
If you really want to do that, I would suggest the attached patch
instead. This just disables the optimization in seqscans to trust it, so
an incorrectly set flag won't affect correctness of query results, but
the flag is still set as usual and you still get the warnings so that we
can continue to debug the issue.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| dont-trust-all-visible-flag.patch | text/x-diff | 633 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernhard Rohrer | 2011-03-03 10:09:40 | Fwd: Re: PG_update to 9.0.4 in ubuntu lucid 64 |
| Previous Message | daveg | 2011-03-03 07:12:08 | Re: [HACKERS] Re: PD_ALL_VISIBLE flag was incorrectly set happend during repeatable vacuum |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-03-03 08:25:30 | Re: Sync Rep v17 |
| Previous Message | Heikki Linnakangas | 2011-03-03 07:43:59 | Re: [PATCH] Add tab completion support for JOIN |