Re: FDW API: don't like the EXPLAIN mechanism

From: Mark Mielke <mark(at)mark(dot)mielke(dot)cc>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: FDW API: don't like the EXPLAIN mechanism
Date: 2011-02-21 16:45:33
Message-ID: 4D6296AD.3010903@mark.mielke.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/21/2011 11:38 AM, Andrew Dunstan wrote:
>
> On 02/21/2011 11:23 AM, Tom Lane wrote:
>> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>>> If we allow the invention of new explain states we'll never be able to
>>> publish an authoritative schema definition of the data. That's not
>>> necessarily an argument against doing it, just something to be aware
>>> of.
>>> Maybe we don't care about having EXPLAIN XML output validated.
>> I thought one of the principal arguments for outputting XML/etc formats
>> was exactly that we'd be able to add fields without breaking readers.
>> If that's not the case, why did we bother?
>>
>
> Well, I thought the motivation was to allow easy construction of
> parsers for the data, since creating a parser for those formats is
> pretty trivial.
> Anyway, if we don't care about validation that's fine. I just didn't
> want us to make that decision unconsciously.

Parsing XML isn't trivial, not if done correctly... :-)

I don't see the benefit of validation beyond test suites, and then the
specification can be published with the version of PostgreSQL (as XSD?)
if so necessary.

Primary benefits include:

1) Open and widely recognized format.
2) Well tested and readily available parsers already exist.
3) Able to easily add content without breaking existing parsers or
analyzers, provided the parsers and analyzers are written properly.

Any XML parser that does: m[<tag>(.*?)</tag>] ... is not written properly.

--
Mark Mielke<mark(at)mielke(dot)cc>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-02-21 16:50:03 Re: FDW API: don't like the EXPLAIN mechanism
Previous Message Alvaro Herrera 2011-02-21 16:45:22 Re: FDW API: don't like the EXPLAIN mechanism