| From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
|---|---|
| To: | Steve Singer <ssinger_pg(at)sympatico(dot)ca> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pl/python explicit subtransactions |
| Date: | 2011-02-12 10:58:39 |
| Message-ID: | 4D5667DF.2060705@wulczer.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/02/11 17:22, Steve Singer wrote:
> On 11-02-10 05:20 AM, Jan Urbański wrote:
>>
>> D'oh, I was thinking about whether it's safe to skip the internal
>> subxact if you're in an implicit one and somehow I always convinced
>> myself that since you eventually close the explicit one, it is.
>>
>> Obviously my testing wasn't enough :( Attaching an updated patch with
>> improved docs incorporating Steve's fixes, and fixes & tests for not
>> statring the implicit subxact. That actually makes the patch a bit
>> smaller ;) OTOH I had to remove the section from the docs that claimed
>> performance improvement due to only starting the explicit subxact...
>>
>
> This version of the patch looks fine to me and seems to work as expected.
Thanks,
attached is a version merged with master.
Jan
| Attachment | Content-Type | Size |
|---|---|---|
| plpython-explicit-subxacts.diff | text/x-patch | 49.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Urbański | 2011-02-12 10:58:50 | Re: pl/python custom exceptions for SPI |
| Previous Message | Ralf Wildenhues | 2011-02-12 10:10:31 | Re: [Mingw-users] mingw64 |