Re: Transaction-scope advisory locks

From: Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Transaction-scope advisory locks
Date: 2011-02-02 15:24:40
Message-ID: 4D497738.2070803@cs.helsinki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2011-01-28 10:12 AM +0200, I wrote:
> I still didn't
> address the issue with pg_advisory_unlock_all() releasing transaction
> scoped locks, but I'm going to.

.. and here's the patch. I'm not too confident with the code I added to
storage/lmgr/lock.c, but it seems to be working.

Earlier there was some discussion about adding regression tests for
advisory locks. However, I don't see where they would fit in our
current .sql files and adding a new one just for a few tests didn't seem
right. Anyone have an idea where they should go or should I just add a
new one?

Regards,
Marko Tiikkaja

Attachment Content-Type Size
advisory4.patch text/plain 34.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2011-02-02 15:46:21 Re: REVIEW: alter extension upgrade (patch v3)
Previous Message Anssi Kääriäinen 2011-02-02 15:08:55 REVIEW: alter extension upgrade (patch v3)