From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Allowing multiple concurrent base backups |
Date: | 2011-01-31 16:31:13 |
Message-ID: | 4D46E3D1.50009@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 27.01.2011 15:15, Fujii Masao wrote:
> When I read the patch, I found that pg_stop_backup removes the backup history
> file as soon as it creates the file, if archive_mode is not enabled.
> This looks like
> oversight. We should prevent pg_stop_backup from removing the fresh history
> file? Or we should prevent pg_stop_backup from creating the history
> file from the
> beginning since it's not used at all if archiving is disabled?
> (If archiving is enabled, the history file can be used to clean the
> archived files up).
Hmm, good point. It's harmless, but creating the history file in the
first place sure seems like a waste of time.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-01-31 16:43:01 | Re: Spread checkpoint sync |
Previous Message | Tom Lane | 2011-01-31 16:29:56 | Re: Spread checkpoint sync |