Re: pgAdmin III: Error on clicking "Display Objects" while doing a restore

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Nikhil S <nixmisc(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III: Error on clicking "Display Objects" while doing a restore
Date: 2011-01-30 16:02:55
Message-ID: 4D458BAF.8020400@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Le 29/01/2011 09:56, Nikhil S a écrit :
> [...]
> The following set of operations induce an error:
>
> 1. Create a backup file /tmp/pg.backup of an existing database
> 2. Create a new database
> 3. Right click and select restore database by specifying this file
> 4. Clicking on "Display Objects" causes the following error: "An error has
> occurred: Schema node not found for object DATABASE postgres [ owner
> postgres ]
>
> The frmRestore::OnEndProcess() function, when it reads the toc information,
> should ignore the line which contains the entry for the dumped database
> itself. So the current code erroneously tries to find the schema to which
> the DATABASE object belongs and gives out the above error. The fix is to
> ignore the input line which contains the db information. The pg_restore
> binary also seems to do the same.
>
> PFA, patch to fix this.
>

Just applied.

This issue was bugging me too, but I couldn't find a proper fix. So,
thanks a lot for this :)

--
Guillaume
http://www.postgresql.fr
http://dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2011-01-30 22:55:24 Add support for directory dump and restore
Previous Message Guillaume Lelarge 2011-01-30 16:02:04 pgAdmin III commit: Fix an error when clicking on "Display objects"