Re: pl/python refactoring

From: Jan Urbański <wulczer(at)wulczer(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pl/python refactoring
Date: 2011-01-20 02:16:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 20/01/11 01:26, Jan Urbański wrote:
> On 19/01/11 10:57, Jan Urbański wrote:
>> On 18/01/11 23:22, Peter Eisentraut wrote:
>>> #2: It looks like this loses some information/formatting in the error
>>> message. Should we keep the pointing arrow there?
>>> CONTEXT: PL/Python function "sql_syntax_error"
>>> -ERROR: syntax error at or near "syntax"
>>> -LINE 1: syntax error
>>> - ^
>>> -QUERY: syntax error
>>> +ERROR: PL/Python: plpy.SPIError: syntax error at or near "syntax"
>>> CONTEXT: PL/Python function "sql_syntax_error"
>> Yes, the message is less informative, because the error is reported by
>> PL/Python, by wrapping the SPI message. I guess I could try to extract
>> more info from the caught ErrorData and put it in the new error that
>> PL/Python throws.
> All right, I found a way to shoehorn the extra information into
> SPIException, I'll post a new patch series with what's left of the
> general refactoring patch soon.

Here's an updated patch series for PL/Python refactoring. It was 16
patches at first, 8 are committed, 1 got dropped, so we're down to 7.


Attachment Content-Type Size
0007-Do-not-prefix-error-messages-with-the-string-PL-Pyth.patch text/x-patch 0 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-01-20 02:22:30 Re: REVIEW: "writable CTEs" - doc patch
Previous Message Stephen Frost 2011-01-20 02:13:36 REVIEW: "writable CTEs" - doc patch