Re: [Pgbuildfarm-members] Buildfarm client version 4.3 released

On 11/08/2010 03:41 AM, Jeremy Drake wrote:
> On Sun, 7 Nov 2010, Andrew Dunstan wrote:
>
>> On 11/07/2010 05:34 PM, Andrew Dunstan wrote:
>>> Buildfarm client version 4.3 has been released. It can be downloaded from
>>> <http://pgfoundry.org/frs/?group_id=1000040>
>>>
>>>
>> A small bug was in this release, so it has been withdrawn, and replaced with a
>> new release 4.4.
> I just upgraded to build-farm-4.4 on mongoose, and got the following
> error:
>
> Can't store REGEXP items at blib/lib/Storable.pm (autosplit into
> blib/lib/auto/Storable/_freeze.al) line 339, at
> /data/local/jeremyd/postgres/build-farm-4.4/run_web_txn.pl line 75
> (Log::Agent could not fix it)
> Web txn failed with status: 255
>
> I am reverting to my previously working version (4.1) for now...

Ouch. That's a sad regression in perl 5.12. Can you try with the
following patch, which I think will fix it?

thanks

andrew

Index: run_web_txn.pl
===================================================================
RCS file: /cvsroot/pgbuildfarm/client-code/run_web_txn.pl,v
retrieving revision 1.9
diff -c -r1.9 run_web_txn.pl
*** run_web_txn.pl 7 Nov 2010 23:35:29 -0000 1.9
--- run_web_txn.pl 8 Nov 2010 09:58:40 -0000
***************
*** 72,77 ****
--- 72,85 ----
$sconf =~ s/.*(\$Script_Config)/$1/ms;
my $Script_Config;
eval $sconf;
+ # very modern Storable modules choke on regexes
+ # the server has no need of them anyway, so just chop them out
+ # they are still there in the text version used for reporting
+ foreach my $k ( keys %$Script_Config )
+ {
+ delete $Script_Config->{$k}
+ if ref($Script_Config->{$k}) eq q(Regexp);
+ }
my $frozen_sconf = nfreeze $Script_Config;

# make the base64 data escape-proof; = is probably ok but no harm done