Re: Complier warnings on mingw gcc 4.5.0

From: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Complier warnings on mingw gcc 4.5.0
Date: 2010-11-01 23:43:35
Message-ID: 4CCF50A7.7000704@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2010/11/02 8:31), Itagaki Takahiro wrote:
> On Tue, Nov 2, 2010 at 6:02 AM, Hiroshi Inoue<inoue(at)tpf(dot)co(dot)jp> wrote:
>>> 1. warning: '<symbol>' redeclared without dllimport attribute:
>>> previous dllimport ignored
>>
>> Is it safe to put back the patch you applied in
>> http://archives.postgresql.org/pgsql-committers/2010-05/msg00338.php
>> in the case __GNUC__>=4?
>
> Hmmm, I didn't test compiling with gcc version between 3.5 and 4.4.
> Does anyone test them? If it works only on gcc 4.5, I'll also add
> _GNUC_MINOR__>= 5 for the check.

The problem which was fixed by your old patch is at runtime not
at compilation time. Is it fixed with gcc 4.5?

regards,
Hiroshi Inoue

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2010-11-02 00:37:43 Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons
Previous Message Itagaki Takahiro 2010-11-01 23:31:46 Re: Complier warnings on mingw gcc 4.5.0