Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to
Date: 2010-10-22 15:42:18
Message-ID: 4CC1B0DA.3070907@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 22.10.2010 18:10, Tom Lane wrote:
> * You forgot a semicolon here:
>
> + | ColId_or_Sconst { $$ = $1 }
> should be
> + | ColId_or_Sconst { $$ = $1; }
>
> I think this will work as-is in some versions of bison, but not all.

Ah yes, it worked for me.

> * The SGML documentation keyword appendix needs an update too, no?

Hmm, I thought the list is automatically updated, but apparently not.

Thanks, fixed.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-10-22 15:42:21 pgsql: Add semicolon, missed in previous patch. And update the keyword
Previous Message Tom Lane 2010-10-22 15:10:28 Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to