Re: Increasing size of results grid

Le 19/10/2010 21:15, Thom Brown a écrit :
> On 19 October 2010 19:43, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>> Le 19/10/2010 08:15, Guillaume Lelarge a écrit :
>>> Le 19/10/2010 00:27, Dave Page a écrit :
>>>> On Mon, Oct 18, 2010 at 10:59 PM, Guillaume Lelarge
>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>> Le 12/10/2010 10:16, Dave Page a écrit :
>>>>>> On Mon, Oct 11, 2010 at 10:37 PM, Guillaume Lelarge
>>>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> Le 11/10/2010 20:54, Josh Berkus a écrit :
>>>>>>>> [...]
>>>>>>>> I'd like to use pgadmin3 for more demos. But I find I can't because the
>>>>>>>> font size of the results grid is fixed as being fairly small, and
>>>>>>>> there's no way to make it larger.
>>>>>>>>
>>>>>>>
>>>>>>> There is a way. Go in the Options window, select the Preferences tab and
>>>>>>> change the Font. It will make, among other components the result grid
>>>>>>> bigger.
>>>>>>
>>>>>> Thats what I thought, but I tested it on Mac and found it didn't work.
>>>>>> wxMac bug?
>>>>>>
>>>>>
>>>>> I think it is more a wxGTK/wxWin bug which changes the font of the cell
>>>>> when you use the function to change the font of the labels.
>>>>>
>>>>> Can someone on Mac tries this patch?
>>>>
>>>> It picks up the main UI font, rather than the Query Tool font (which
>>>> is used by ctlSQLBox). I'm not sure that's the appropriate behaviour.
>>>> It also forces it to bold, because that's how the column/row headers
>>>> are shown.
>>>>
>>>
>>> Yeah, just wanted to make sure we had to use the SetDefaultCellFont()
>>> method.
>>>
>>> Will use the Query Tool font.
>>>
>>
>> Done.
>>
>>>> We'd also need to ensure it also affects the edit grid, and other
>>>> grids we may be using such as those on the debugger.
>>>>
>>>
>>> +1
>>>
>>
>> If they use the ctlSQLResult, they should be fine. I tried on the edit
>> grid and it worked.
>>
>> Two patchs attached: one for the font customization (which could be
>> commited to 1.12 and master), one for the mousewheel support (which will
>> only be applied to master).
>>
>> Any comments before I commit them?
>
> Yes, the scrollwheel zoom should really also increase the height of
> rows and size of text on column titles/row numbers too if that's
> possible.

You're right. Done in this new attached patch.

> And I'm wondering if the zoom should be persistent.
>

No, I don't think so. Maybe someone has a stronger opinion on this?

--
Guillaume
http://www.postgresql.fr
http://dalibo.com