Re: automatic sql formating ?

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Andreas <maps(dot)on(at)gmx(dot)net>
Cc: PgAdmin Support <pgadmin-support(at)postgresql(dot)org>
Subject: Re: automatic sql formating ?
Date: 2010-10-06 09:42:35
Message-ID: 4CAC448B.1040407@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Le 02/10/2010 02:14, Andreas a écrit :
> Am 02.10.2010 01:04, schrieb Guillaume Lelarge:
>> Le 02/10/2010 00:52, Andreas a écrit :
>>> Is there a way to extend the syntax highlighting to setting sql commands
>>> in upper ?
>>>
>>> [...]
>> I keep getting asked to have that kind of functionalities. It would be a
>> really great feature to add. It's also a really difficult one to code.
>>
> But pgAdmin does right this everywhere on it's sql-fields e.g. when it
> displays the create command for a table. So I suppose the algorithm to
> parse sql code exists allready somewhere.
>

You're right. And as a matter of fact, it's quite easy. Here is the diff
to handle this:

diff --git a/pgadmin/ctl/ctlSQLBox.cpp b/pgadmin/ctl/ctlSQLBox.cpp
index 3cd5577..26cdb9c 100644
--- a/pgadmin/ctl/ctlSQLBox.cpp
+++ b/pgadmin/ctl/ctlSQLBox.cpp
@@ -114,6 +114,8 @@ void ctlSQLBox::Create(wxWindow *parent, wxWindowID
id, const wxPoint& pos, cons
StyleSetFont(i, fntSQLBox);
}

+ StyleSetCase(5, wxSTC_CASE_UPPER);
+
// Margin style
StyleSetBackground(wxSTC_STYLE_LINENUMBER,
settings->GetSQLMarginBackgroundColour());

But I think we should have an option to activate this. I'm gonna work on
it, unless someone wants to do it before :)

> Probaply it's hard to do it on the fly in the editor.
> A editor command would do, though. So one writes the code in the rough
> and when it works push some key or icon and the text in the editor gets
> reformatted.
>
> But this would be just something for the nice-to-have list. :)
>

Yeah, I added a ticket (#250) for this.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Tom Lane 2010-10-06 13:41:16 Re: [ADMIN] Can't access tables.
Previous Message Guillaume Lelarge 2010-10-06 09:03:26 Re: cells and more