Re: Ticket #223

Le 26/08/2010 21:36, Guillaume Lelarge a écrit :
> Le 26/08/2010 17:40, Steffen Kuhn a écrit :
>> Hi Guillaume,
>>
>> first of all: you are quite hardworking today.
>>
>> I thought about #223 because I really don't like app crashes.
>> WxWigets tells me that frames opened before app main loop are not
>> destroyed.
>> (http://docs.wxwidgets.org/2.8/wx_wxappoverview.html#wxappshutdownoverview)
>>
>> So I see there two possibilites:
>> _1 Say this is feature like wxWidgets does and care about not unchecked
>> accessing frmMain in frmQuery which is not null but invalid in frmQuery
>> _2 Close descendant frames on frmMain exit, by either delegate opening
>> to frmMain so this is done by default or take care about in
>> frmMain::OnCLose
>> or pgAdmin3::OnExit
>> What do you think about this.
>>
>
> I actually don't think it is a good idea to allow a user to use both -q
> and -s at the same time. If you use -q, it means you don't want to use
> the browser. But -s launches the browser. Kind of weird, don't you
> think? so my question is: why would anyone use both of them at the same
> time? (the same question goes for -S and -s)
>
>

BTW, we have the same issue with the frmStatus window. This window can
launch a frmQuery window, but it won't notify the frmMain window. If you
open a frmQuery window from the frmStatus one, and then close the
frmMain window, the frmQuery window will stay open and won't quit. Next
time you fire some SQL statement or change your connection, kaboom :)

--
Guillaume
http://www.postgresql.fr
http://dalibo.com